[IMP] tables: introduce dynamic tables #3624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hokolomopo
changed the title
hokolomopo
force-pushed
the
master-table-style-adrm
branch
from
1bce42f
to
c3df937
Compare
hokolomopo
changed the title
hokolomopo
force-pushed
the
master-table-style-adrm
branch
from
c3df937
to
dbea100
Compare
hokolomopo
force-pushed
the
master-table-style-adrm
branch
5 times, most recently
from
7ac2d90
to
891baa3
Compare
hokolomopo
force-pushed
the
master-table-style-adrm
branch
3 times, most recently
from
ebeac35
to
6f04814
Compare
hokolomopo
force-pushed
the
master-dynamic-table-style-adrm
branch
2 times, most recently
from
e97c439
to
7d12eeb
Compare
hokolomopo
force-pushed
the
master-dynamic-table-style-adrm
branch
2 times, most recently
from
f6b299d
to
4e3b7a4
Compare
|
THe first commit definitely deserves to be backported |
rrahir
reviewed
Mar 5, 2024
src/plugins/core/tables.ts
Outdated
| for (const table of this.getTables(cmd.sheetId)) { | ||
| if (cmd.target.every((zone) => !intersection(zone, table.range.zone))) { | ||
| const tables: Record<UID, InternalTable> = {}; | ||
| for (const table of this.getInternalTables(cmd.sheetId)) { |
There was a problem hiding this comment.
It was already present before but this command can technically delete several tables at a time. should the command have been targeting the exact table zone definition all along?
There was a problem hiding this comment.
Probably could have been a good way to do it, but at the time it would have required a bit more logic in the menu items for no real reason.
Now I'm stuck with it, I don't see how I would migrate the revisions correctly in python.
LucasLefevre
reviewed
Mar 5, 2024
hokolomopo
force-pushed
the
master-dynamic-table-style-adrm
branch
2 times, most recently
from
bb40f87
to
9030d22
Compare
hokolomopo
force-pushed
the
master-dynamic-table-style-adrm
branch
2 times, most recently
from
6f94bb1
to
68f43b1
Compare
hokolomopo
force-pushed
the
master-dynamic-table-style-adrm
branch
2 times, most recently
from
7952c80
to
52e8b03
Compare
hokolomopo
force-pushed
the
master-dynamic-table-style-adrm
branch
from
52e8b03
to
ba972c9
Compare
Before this the getter `getSpreadPositionsOf` only returned the position of the cells an array formula was spread to, minus the cell the array formula was in. This made it impossible to differentiate between a cell with a normal formula, and a cell with an array formula returning a 1x1 matrix. Now the getter returns the root position of the array formula as well. The getter `getArrayFormulaSpreadingOn` was also modified to work when calling it on the root position of an array formula. There was also a bug where the spread relation weren't properly cleaned. Task: 3707037
hokolomopo
force-pushed
the
master-dynamic-table-style-adrm
branch
from
ba972c9
to
1e9a5d1
Compare
This commit introduces the concept of dynamic table. A dynamic table is a table that is bound to a array formula, instead of a static range. The table will grow and shrink along the results of the array formula. This means that the table zones are now an UI concept. The core plugin now manages `CoreTable` objects, that can be either static or dynamic (in which case they don't have a zone, but a single cell position). The UI plugin `DynamicTablesPlugin` transform those `CoreTable` into `Table` objects that every other plugin and component can easily use. As the core plugin doesn't have access to the evaluation results, and can't know if a cell contains an array formula, it's the responsibility of the components that create a table to determine if it's dynamic or not. It is now not possible to keep the same filtered values in a copied table, since an UPDATE_CELL will invalidate the tables of the `DynamicTablesPlugin` until the next finalize, and thus `UPDATE_FILTER` won't work in the clipboard. Task: 3707037
hokolomopo
force-pushed
the
master-dynamic-table-style-adrm
branch
from
1e9a5d1
to
891e892
Compare
LucasLefevre
approved these changes
Mar 25, 2024
|
Merge method set to rebase and fast-forward. |
|
robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward. |
|
I'm sorry, @VincentSchippefilt: this PR is already reviewed, reviewing it again is useless. |
robodoo
pushed a commit
that referenced
this pull request
Mar 25, 2024
Before this the getter `getSpreadPositionsOf` only returned the position of the cells an array formula was spread to, minus the cell the array formula was in. This made it impossible to differentiate between a cell with a normal formula, and a cell with an array formula returning a 1x1 matrix. Now the getter returns the root position of the array formula as well. The getter `getArrayFormulaSpreadingOn` was also modified to work when calling it on the root position of an array formula. There was also a bug where the spread relation weren't properly cleaned. Task: 3707037 Part-of: #3624
robodoo
pushed a commit
that referenced
this pull request
Mar 25, 2024
This commit introduces the concept of dynamic table. A dynamic table is a table that is bound to a array formula, instead of a static range. The table will grow and shrink along the results of the array formula. This means that the table zones are now an UI concept. The core plugin now manages `CoreTable` objects, that can be either static or dynamic (in which case they don't have a zone, but a single cell position). The UI plugin `DynamicTablesPlugin` transform those `CoreTable` into `Table` objects that every other plugin and component can easily use. As the core plugin doesn't have access to the evaluation results, and can't know if a cell contains an array formula, it's the responsibility of the components that create a table to determine if it's dynamic or not. It is now not possible to keep the same filtered values in a copied table, since an UPDATE_CELL will invalidate the tables of the `DynamicTablesPlugin` until the next finalize, and thus `UPDATE_FILTER` won't work in the clipboard. closes #3624 Task: 3707037 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IMP] tables: introduce dynamic tables
This commit introduces the concept of dynamic table. A dynamic table
is a table that is bound to a array formula, instead of a static range.
The table will grow and shrink along the results of the array formula.
The notion is transparent to the user: if the users defines a table on
a single cell that contains an array formula, or all the cells of the
array formula, the table will be dynamic.
This means that the table zones are now an UI concept. The core plugin
now manages
InternalTableobjects, that can be either static ordynamic (in which case they don't have a zone, but a single cell position).
The UI plugin
DynamicTablesPlugintransform thoseInternalTableintoTableobjects that every other plugin and component can easily use.As the core plugin doesn't have access to the evaluation results, and
can't know if a cell contains an array formula, it's the responsability
of the components that create a table to determine if it's dynamic or not.
[IMP] array formula:
getSpreadPositionsOfnow returns root positionBefore this the getter
getSpreadPositionsOfonly returned theposition of the cells an array formula was spread to, minus the
cell the array formula was in. This made it impossible to differentiate
between a cell with a normal formula, and a cell with an array formula
returning a 1x1 matrix.
Now the getter returns the root position of the array formula as well.
There was also a bug where the spread relation weren't properly cleaned.
Task: 3707037
review checklist