[FW][FIX] selection_inputs_manager: arrow keys when broken ranges #3745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdout: Auto-merging src/components/selection_input/selection_input.ts Auto-merging src/plugins/ui_feature/selection_inputs_manager.ts CONFLICT (content): Merge conflict in src/plugins/ui_feature/selection_inputs_manager.ts Auto-merging tests/selection_input/selection_input_plugin.test.ts stderr: 17:53:56.250784 git.c:463 trace: built-in: git cherry-pick cfad8ae error: could not apply cfad8ae... [FIX] selection_inputs_manager: arrow keys when broken ranges hint: After resolving the conflicts, mark them with hint: "git add/rm <pathspec>", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". ---------- status: X-original-commit: 89ead135631922f5147c7e828c48075fc5b6b4a3
|
@dhrp-odoo @rrahir this PR targets saas-17.1 and is the last of the forward-port chain. To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
rrahir
pushed a commit
that referenced
this pull request
Feb 26, 2024
Previously, the arrow keys failed to function as expected when broken ranges were present in the selection input. Steps to reproduce: From the side panel of a chart with a SelectionInput containing two ranges: - Enter a valid range in the second input. - Corrupt the first input by entering "A11wwwz". - Press Enter to confirm. - Reselect the first range. - Attempt to use the keyboard arrows to change the zone; however, this does not work. - Select the second input. - Attempt to use the keyboard arrows to change the zone; again, this does not work. To address this issue, the if statement in command handling from the plugin was removed to ensure it allows capturing the range. closes #3745 Task: 3626171 X-original-commit: 89ead135631922f5147c7e828c48075fc5b6b4a3 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com> Signed-off-by: Dhrutik Patel (dhrp) <dhrp@odoo.com>
fw-bot
deleted the
saas-17.1-saas-16.1-fix-selection-input-with-broken-ranges-dhrp-zOaC-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously, the arrow keys failed to function as expected when broken ranges were present in the selection input.
Steps to reproduce:
From the side panel of a chart with a SelectionInput containing two ranges:
To address this issue, the if statement in command handling from the plugin was removed to ensure it allows capturing the range.
Task: : 3626171
review checklist
Forward-Port-Of: #3727
Forward-Port-Of: #3675