[FIX] evaluation: accept 1x1 result array in sub-formula #3750
Conversation
|
Possibility to go further and remove refFn in compilation parameters. POC #3747 |
laa-odoo
force-pushed
the
17.0-fix-evaluation-type-guard-laa
branch
from
de45464
to
5c4af69
Compare
src/functions/index.ts
Outdated
| const argDefinition = descr.args[descr.getArgToFocus(i + 1) - 1]; | ||
| const acceptMatrix = argDefinition.type.some((t) => t.startsWith("RANGE")); |
There was a problem hiding this comment.
I can measure a performance hit of ~+4.5% (on RNG's spreadsheet)
maybe we can try to move those two lines to check if the arg accepts a matrix outside of return function (this: EvalContext, ... to compute it only once (keep an array of booleans)
There was a problem hiding this comment.
to know if arg accept matrix or not, an attribute was added on argFunctionDecription.
The attribute is computed when formula is added to the formula registry.
If ok for you, I fixup the last commit
laa-odoo
force-pushed
the
17.0-fix-evaluation-type-guard-laa
branch
from
5c4af69
to
116228e
Compare
Before this commit, when a formula function expected a simple argument, and it received an array, we transformed the array into a simple argument if the array was of size 1x1 However, this process was only done when reading the references to the ranges. This commit extends the process when the result array comes from a sub-formula and no longer range references. Task 3756474
LucasLefevre
force-pushed
the
17.0-fix-evaluation-type-guard-laa
branch
from
116228e
to
b113dfb
Compare
Description:
Before this commit, when a formula function
expected a simple argument, and it received
an array, we transformed the array into a
simple argument if the array was of size 1x1
However, this process was only done when
reading the references to the ranges.
This commit extends the process when the result
array comes from a sub-formula and no longer
range references.
Task: : 3756474
review checklist