[FW][IMP] cssPropertiesToCss: don't use Object.entries()
#3751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Object.entries()` allocate a new array, which will need to be garbage collected later. Not using that reduce the memory usage from `cssPropertiesToCss` from ~0.75% of total memory when scrolling a sheet to ~0.25% of total. There are other uses of `Object.entries()` in the code base, but their impact are too negligible to matter. X-original-commit: fd9e140
|
This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@hokolomopo @LucasLefevre the next pull request (#3752) is in conflict. You can merge the chain up to here by saying
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Feb 27, 2024
`Object.entries()` allocate a new array, which will need to be garbage collected later. Not using that reduce the memory usage from `cssPropertiesToCss` from ~0.75% of total memory when scrolling a sheet to ~0.25% of total. There are other uses of `Object.entries()` in the code base, but their impact are too negligible to matter. closes #3751 X-original-commit: fd9e140 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object.entries()allocate a new array, which will need to be garbage collected later. Not using that reduce the memory usage fromcssPropertiesToCssfrom ~0.75% of total to ~0.25% of total.There are other uses of
Object.entries()in the code base, but their impact are too negligible to matter.Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist
Forward-Port-Of: #3748