[FW][FIX] migration: Fix migration steps #3760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The forward-port fix in #3632 was incorrect as it did not adapted the (already present) following migration step to be exectued after step 12.5 and not step 12. In the current state, a user coming from version 16.2 and below will not be able to migrate their data as their current version (12.5) does not match any 'from' of the migration steps. OPW 3757136 Task: 3771209 X-original-commit: 8ab9ce7
The fix proposed in #3632 will only work if the data are actually migrated, i.e. when the loaded data is from a version before 12.5. Unfortunately, a lot of time passed before we discovered the issue and the spreadsheet version was updated several times. To ensure the data integrity accross all versions, we have to duplicate the migration of the data filter so that every current active version can benefit from it. Task: 3728009 X-original-commit: 9761a31
|
This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@rrahir @pro-odoo the next pull request (#3761) is in conflict. You can merge the chain up to here by saying
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Feb 28, 2024
The forward-port fix in #3632 was incorrect as it did not adapted the (already present) following migration step to be exectued after step 12.5 and not step 12. In the current state, a user coming from version 16.2 and below will not be able to migrate their data as their current version (12.5) does not match any 'from' of the migration steps. OPW 3757136 Task: 3771209 X-original-commit: 8ab9ce7 Part-of: #3760
robodoo
pushed a commit
that referenced
this pull request
Feb 28, 2024
The fix proposed in #3632 will only work if the data are actually migrated, i.e. when the loaded data is from a version before 12.5. Unfortunately, a lot of time passed before we discovered the issue and the spreadsheet version was updated several times. To ensure the data integrity accross all versions, we have to duplicate the migration of the data filter so that every current active version can benefit from it. closes #3760 Task: 3728009 X-original-commit: 9761a31 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com> Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
fw-bot
deleted the
saas-17.1-saas-16.3-fix-migration-opw-3632-rar-6XLb-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forward-port fix in #3632 was incorrect as it did not adapted the (already present) following migration step to be exectued after step 12.5 and not step 12. In the current state, a user coming from version 16.2 and below will not be able to migrate their data as their current version (12.5) does not match any 'from' of the migration steps.
OPW 3757136
Task: 3771209
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist
Forward-Port-Of: #3758
Forward-Port-Of: #3756