[PERF] functions: return #N/A instead of throwing #3772
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasLefevre
force-pushed
the
saas-17.1-faster-not-available-lookup-lul
branch
from
c238927
to
1527172
Compare
hokolomopo
reviewed
Feb 29, 2024
LucasLefevre
force-pushed
the
saas-17.1-faster-not-available-lookup-lul
branch
from
1527172
to
4001306
Compare
Throwing errors is very slow compared to returning.
On an empty sheet, except 10K `=VLOOKUP("qsdf", B:C,1,0)` in column A:
Evaluation:
before: 699ms
after: 409ms (-40%)
(average over 6 runs)
Task: 3775565
LucasLefevre
force-pushed
the
saas-17.1-faster-not-available-lookup-lul
branch
from
4001306
to
e55b86f
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 8, 2024
Throwing errors is very slow compared to returning.
On an empty sheet, except 10K `=VLOOKUP("qsdf", B:C,1,0)` in column A:
Evaluation:
before: 699ms
after: 409ms (-40%)
(average over 6 runs)
closes #3772
Task: 3775565
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Throwing errors is very slow compared to returning.
On an empty sheet, except 10K cells with
=VLOOKUP("qsdf", B:C,1,0)in column A:Evaluation:
(average over 6 runs)
Task: : 3775565
review checklist