-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] tables: set table color in custom colors #3776
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hokolomopo
changed the title
Master table color custom colors adrm
[IMP] tables: set table color in custom colors
Feb 29, 2024
hokolomopo
force-pushed
the
master-table-color-custom-colors-adrm
branch
from
February 29, 2024 13:30
e2d0d17
to
3671d0a
Compare
LucasLefevre
reviewed
Mar 1, 2024
When inserting a table with a style in the sheet, it could be useful for the user to be able to paint cells in the same colors as the table cells. This commit adds the table colors to the custom colors plugin, so they are available to the user. Another idea would have been to replace the color pickers colors by the table colors. But then we end up with dull and sad colors in the color picker so we gave up on that. Also fixed some bugs and strange behaviors in the custom colors plugin: - we compute and store the custom colors at each finalize, but the getter `getCustomColors` was re-computing the colors instead of using the stored ones. - the colors stored by the plugin weren't loaded at import until a command modifying the colors was executed. - the colors were filtered/validated multiple times (once when computing the colors, and once when adding them to the plugin state). - the colors were sorted, then added to a POJO, making the sorting useless. Task: 3775936
This commit aims to reduce the number of custom colors during a normal use of a spreadsheet and in the demo by replacing custom colors by colors present in the color picker. The following were changed: - default scorecard baseline colors - CF up/down arrows icons - lot of demo data colors and their equivalent in the demo test xlsx Task: 3775936
hokolomopo
force-pushed
the
master-table-color-custom-colors-adrm
branch
from
March 1, 2024 13:24
3671d0a
to
55c3f04
Compare
LucasLefevre
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
robodoo r+ rebase-ff
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Mar 4, 2024
When inserting a table with a style in the sheet, it could be useful for the user to be able to paint cells in the same colors as the table cells. This commit adds the table colors to the custom colors plugin, so they are available to the user. Another idea would have been to replace the color pickers colors by the table colors. But then we end up with dull and sad colors in the color picker so we gave up on that. Also fixed some bugs and strange behaviors in the custom colors plugin: - we compute and store the custom colors at each finalize, but the getter `getCustomColors` was re-computing the colors instead of using the stored ones. - the colors stored by the plugin weren't loaded at import until a command modifying the colors was executed. - the colors were filtered/validated multiple times (once when computing the colors, and once when adding them to the plugin state). - the colors were sorted, then added to a POJO, making the sorting useless. Task: 3775936 Part-of: #3776
robodoo
pushed a commit
that referenced
this pull request
Mar 4, 2024
This commit aims to reduce the number of custom colors during a normal use of a spreadsheet and in the demo by replacing custom colors by colors present in the color picker. The following were changed: - default scorecard baseline colors - CF up/down arrows icons - lot of demo data colors and their equivalent in the demo test xlsx closes #3776 Task: 3775936 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
[IMP] table: add table colors to custom colors
When inserting a table with a style in the sheet, it could be useful
for the user to be able to paint cells in the same colors as the table
cells.
This commit adds the table colors to the custom colors plugin, so they
are available to the user.
Another idea would have been to replace the color pickers colors by
the table colors. But then we end up with dull and sad colors in the
color picker so we gave up on that.
Also fixed some bugs and strange behaviors in the custom colors plugin:
getter
getCustomColors
was re-computing the colors instead of usingthe stored ones.
command modifying the colors was executed.
the colors, and once when adding them to the plugin state).
[IMP] colors: reduce number of custom colors
This commit aims to reduce the number of custom colors during a
normal use of a spreadsheet and in the demo by replacing custom colors
by colors present in the color picker.
The following were changed:
Task: : 3775936
review checklist