Master table autofill adrm #3783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasLefevre
reviewed
Mar 7, 2024
| if (row !== selection.bottom) { | ||
| this.select(activePosition.col, row); | ||
| for (let row = selection.bottom + 1; row <= autofillRow; row++) { | ||
| if (this.getters.getEvaluatedCell({ ...activePosition, row }).type !== CellValueType.empty) { |
There was a problem hiding this comment.
I'm afraid you have to check the core cell because a function can return an empty evaluated cell (think about odoo pivot functions) and you don't want the formula to be overwritten in this case.
This commit improves the `AUTOFILL_AUTO` command for tables. Now when auto filling a cell in a table, we will autofill until the end of the table. Task: 3777825
The autofill done in the `AUTOFILL_AUTO` command wasn't checking if the cells already had a content, and thus could overwrite cells. This commit add a check to stop the autofill at the first non-empty cell encountered. Task: 3777825
LucasLefevre
force-pushed
the
master-table-autofill-adrm
branch
from
b8c5119
to
7df4a94
Compare
LucasLefevre
approved these changes
Mar 7, 2024
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Mar 7, 2024
This commit improves the `AUTOFILL_AUTO` command for tables. Now when auto filling a cell in a table, we will autofill until the end of the table. Task: 3777825 Part-of: #3783
robodoo
pushed a commit
that referenced
this pull request
Mar 7, 2024
The autofill done in the `AUTOFILL_AUTO` command wasn't checking if the cells already had a content, and thus could overwrite cells. This commit add a check to stop the autofill at the first non-empty cell encountered. closes #3783 Task: 3777825 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
[IMP] autofill:
AUTOFILL_AUTOfor tablesThis commit improves the
AUTOFILL_AUTOcommand for tables. Now whenauto filling a cell in a table, we will autofill until the end of the
table.
Task: : 3777825
[FIX] autofill:
AUTOFILL_AUTOoverwrite cellsThe autofill done in the
AUTOFILL_AUTOcommand wasn't checking ifthe cells already had a content, and thus could overwrite cells.
This commit add a check to stop the autofill at the first non-empty
cell encountered.
Task: : 3777825
review checklist