Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] table: automatic autofill formula in table #3787

Closed
wants to merge 1 commit into from
Closed

[IMP] table: automatic autofill formula in table #3787

wants to merge 1 commit into from

Conversation

hokolomopo
Copy link
Contributor

Description

When the user inputs a formula in a table, it should be automatically autofilled in the table column.

That is handled in the new TableAutofillPlugin that handles the command AUTOFILL_TABLE_COLUMN that is fired but the composerStore after editing a cell, and by the clipboard on paste.

Task: : 3777873

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Mar 4, 2024

Pull request status dashboard.

LucasLefevre
LucasLefevre reviewed Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a small bug

src/clipboard_handlers/tables_clipboard.ts Outdated Show resolved Hide resolved
@hokolomopo
[IMP] table: automatic autofill formula in table
235d341 
When the user inputs a formula in a table, it should be automatically
autofilled in the table column.

That is handled in the new `TableAutofillPlugin` that handles the
command `AUTOFILL_TABLE_COLUMN` that is fired but the composerStore
after editing a cell, and by the clipboard on paste.

Task: 3777873
@hokolomopo hokolomopo force-pushed the master-table-formula-autofill-adrm branch from 4fe8f3e to 235d341 Compare March 8, 2024 09:42
LucasLefevre
LucasLefevre approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+
Thanks :)

robodoo pushed a commit that referenced this pull request Mar 8, 2024
@hokolomopo
[IMP] table: automatic autofill formula in table
6e67338 
When the user inputs a formula in a table, it should be automatically
autofilled in the table column.

That is handled in the new `TableAutofillPlugin` that handles the
command `AUTOFILL_TABLE_COLUMN` that is fired but the composerStore
after editing a cell, and by the clipboard on paste.

closes #3787

Task: 3777873
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo added the 17.2 label Mar 8, 2024
@robodoo robodoo closed this Mar 8, 2024
@fw-bot fw-bot deleted the master-table-formula-autofill-adrm branch March 22, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasLefevre LucasLefevre LucasLefevre approved these changes

Assignees
No one assigned
Labels
17.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hokolomopo @robodoo @LucasLefevre