[FW][IMP] data validation: performance of icons #3788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A sheet with a lot of data validation icons was slow to render, because: - we loop on all the cells of the data validation, and not only the visible cells - we created components even for non-visible cells - we use `getColDimensionsInViewport` which is slow This commit fixes all of the above. We go from ~10fps to ~45fps when scrolling the sheet. We could be even faster by not using components and only t-call to templates, but the world isn't ready yet. Task: 3773923 X-original-commit: cb53fc2
Task: 3773923 X-original-commit: cd9bcee
|
This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@hokolomopo @LucasLefevre the next pull request (#3789) is in conflict. You can merge the chain up to here by saying
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
fw-bot r+
…On Tue, Mar 5, 2024 at 9:06 AM Otis - Odoo Forward-Port Steward [bot] < ***@***.***> wrote:
@hokolomopo <https://github.com/hokolomopo> @LucasLefevre
<https://github.com/LucasLefevre> the next pull request (#3789
<#3789>) is in conflict. You
can merge the chain up to here by saying
@fw-bot <https://github.com/fw-bot> r+
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port
—
Reply to this email directly, view it on GitHub
<#3788 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACTHFEMXPPNRR26QIGYY2D3YWV4HPAVCNFSM6AAAAABEGT5DZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZYGE3TCNJZHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
robodoo
pushed a commit
that referenced
this pull request
Mar 5, 2024
A sheet with a lot of data validation icons was slow to render, because: - we loop on all the cells of the data validation, and not only the visible cells - we created components even for non-visible cells - we use `getColDimensionsInViewport` which is slow This commit fixes all of the above. We go from ~10fps to ~45fps when scrolling the sheet. We could be even faster by not using components and only t-call to templates, but the world isn't ready yet. Task: 3773923 X-original-commit: cb53fc2 Part-of: #3788
fw-bot
deleted the
saas-17.1-17.0-data-validation-performances-adrm-aOcc-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A sheet with a lot of data validation icons was slow to render, because:
getColDimensionsInViewportwhich is slowThis commit fixes all of the above. We go from ~10fps to ~45fps when scrolling the sheet.
We could be even faster by not using components and only t-call to templates, but the world isn't ready yet.
Task: : 3773923
review checklist
Forward-Port-Of: #3770