[FIX] evaluation: ensure value to evaluated cell #3800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -261,7 +261,7 @@ export class Evaluator { | |||
| ? this.computeFormulaCell(cellPosition.sheetId, cell) | |||
| : evaluateLiteral(cell.content, localeFormat); | |||
| } catch (e) { | |||
| return createEvaluatedCell(e.value, localeFormat, e.message); | |||
| return createEvaluatedCell(e.value || CellErrorType.GenericError, localeFormat, e.message); | |||
There was a problem hiding this comment.
Suggested change
| return createEvaluatedCell(e.value || CellErrorType.GenericError, localeFormat, e.message); | |
| return createEvaluatedCell(e?.value || CellErrorType.GenericError, localeFormat, e?.message || "some default message"); |
it is possible to throw an undefined error as well
When the evaluation process fails, we catch the error and assume it is an `EvaluationError` but it's not always the case (i.e., `evaluateLiteral` can also fail in some situations [^1]) and the error.value can be undefined, which breaks the typing of `createEvaluatedFormula`. THis revision adds a default value to avoid this situation. [^1]: Currently, this can happen if we try to define a link cell in which the label starts with an "=". That issue will be sorted out in another commit.
rrahir
force-pushed
the
saas-17.1-eval-error-rar
branch
from
03bfa63
to
bd021af
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 8, 2024
When the evaluation process fails, we catch the error and assume it is an `EvaluationError` but it's not always the case (i.e., `evaluateLiteral` can also fail in some situations [^1]) and the error.value can be undefined, which breaks the typing of `createEvaluatedFormula`. THis revision adds a default value to avoid this situation. [^1]: Currently, this can happen if we try to define a link cell in which the label starts with an "=". That issue will be sorted out in another commit. closes #3800 Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the evaluation process fails, we catch the error and assume it is an
EvaluationErrorbut it's not always the case (i.e.,evaluateLiteralcan also fail in some situations 1) and the error.value can be undefined, which breaks the typing ofcreateEvaluatedFormula. THis revision adds a default value to avoid this situation.Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist
Footnotes
Currently, this can happen if we try to define a link cell in which the label starts with an "=". That issue will be sorted out in another commit. ↩