Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] DataValidationCheckbox: Fix input positioning in FF #3803

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Mar 8, 2024

It turns out that an input[checkbox] box position is affected by the current font-size of its containing node in Firefox.

Task: 3774645

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3795

It turns out that an input[checkbox] box position is affected by the
current font-size of its containing node in Firefox.

Task: 3774645
X-original-commit: 8ac8ce5
@robodoo
Copy link
Collaborator

robodoo commented Mar 8, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Mar 8, 2024

This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

robodoo pushed a commit that referenced this pull request Mar 8, 2024
It turns out that an input[checkbox] box position is affected by the
current font-size of its containing node in Firefox.

closes #3803

Task: 3774645
X-original-commit: 8ac8ce5
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
@robodoo robodoo closed this Mar 8, 2024
@fw-bot fw-bot deleted the saas-17.1-17.0-fix-checkbox-pos-rar-r3zH-fw branch March 22, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants