[IMP] LinkDisplay: update grid selection before opening the editor #3809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| onMounted(() => this.urlInput.el?.focus()); | ||
| onMounted(() => { | ||
| const { col, row } = this.props.cellPosition; | ||
| this.env.model.selection.selectCell(col, row); |
There was a problem hiding this comment.
maybe select the cell in link_display.ts before opening the component to avoid modifying the state here, which would trigger a double render?
There was a problem hiding this comment.
Agreed :) change made and update the commit message
rrahir
force-pushed
the
master-sync-link-editor-and-selection-rar
branch
from
a5aaf38
to
353da93
Compare
rrahir
changed the title
Currently, a user can open the link editor of a cell while hovering it but not selectd. This behaviour is counterintuitive as once the link editor is opened, we will close it if we change the selection. This revision ensures that the link editor target and the selection are synchronized upon the initialization of the the former. Task: 3793859
LucasLefevre
force-pushed
the
master-sync-link-editor-and-selection-rar
branch
from
353da93
to
c4cb2fd
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 22, 2024
Currently, a user can open the link editor of a cell while hovering it but not selectd. This behaviour is counterintuitive as once the link editor is opened, we will close it if we change the selection. This revision ensures that the link editor target and the selection are synchronized upon the initialization of the the former. closes #3809 Task: 3793859 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a user can open the link editor of a cell while hovering it but not selectd. This behaviour is counterintuitive as once the link editor is opened, we will close it if we change the selection.
This revision ensures that the link editor target and the selection are synchronized upon the initialization of the the former.
Task: 3793859
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist