[FW][FIX] FiguresContainer: chart resizing broken #3824
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the chart resizing didn't work properly when the viewport was scrolled and only part of the figure was visible. This commit addresses the issue by enhancing the condition to check if the figure extends beyond the header boundaries. Now, this condition also considers scrolling, ensuring proper chart resizing. Task ID: 3752060 X-original-commit: e87e56c
|
This PR targets saas-16.4 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
14 tasks
robodoo
pushed a commit
that referenced
this pull request
Mar 13, 2024
Previously, the chart resizing didn't work properly when the viewport was scrolled and only part of the figure was visible. This commit addresses the issue by enhancing the condition to check if the figure extends beyond the header boundaries. Now, this condition also considers scrolling, ensuring proper chart resizing. Task ID: 3752060 closes #3824 X-original-commit: e87e56c Signed-off-by: Rémi Rahir (rar) <rar@odoo.com> Signed-off-by: Dhrutik Patel (dhrp) <dhrp@odoo.com>
fw-bot
deleted the
saas-16.4-16.0-fix-chart-resizing-broken-dhrp-s9nb-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously, the chart resizing didn't work properly when the viewport was scrolled and only part of the figure was visible.
This commit addresses the issue by enhancing the condition to check if the figure extends beyond the header boundaries. Now, this condition also considers scrolling, ensuring proper chart resizing.
Task: : 3752060
review checklist
Forward-Port-Of: #3822
Forward-Port-Of: #3785