Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] sheet_interactive: rename sheet in readonly mode #3826

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Mar 13, 2024

Description:

This PR addresses two distinct issues identified in the current codebase.

Commit 1:

  • Resolves an issue where renaming a sheet with whitespace failed to trigger the sheet rename dialog.
  • Implements whitespace trimming for sheet names to ensure the dialog opens as intended.

Commit 2:

  • The commit rectifies an issue where users in readonly mode were able to invoke the sheet renaming dialog by double clicking on its name. However, they were unable to complete the renaming process in readonly mode.
  • Introduces an early return, preventing the invocation of the renaming dialog altogether when the application is in readonly mode.

Task: : 3621086

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3815
Forward-Port-Of: #3345

The commit rectifies an issue where users in readonly mode were able
to invoke the sheet renaming input by double clicking on its name.

Introduces an early return, preventing the invocation of the renaming
input altogether when the application is in readonly mode.

Taskid: 3621086
X-original-commit: 1e73672
@robodoo
Copy link
Collaborator

robodoo commented Mar 13, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Mar 13, 2024

This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

robodoo pushed a commit that referenced this pull request Mar 13, 2024
The commit rectifies an issue where users in readonly mode were able
to invoke the sheet renaming input by double clicking on its name.

Introduces an early return, preventing the invocation of the renaming
input altogether when the application is in readonly mode.

closes #3826

Taskid: 3621086
X-original-commit: 1e73672
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Dhrutik Patel (dhrp) <dhrp@odoo.com>
@robodoo robodoo closed this Mar 13, 2024
@fw-bot fw-bot deleted the saas-17.1-16.0-fix-bugs-regarding-sheet-name-dhrp-1JUt-fw branch March 27, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants