[IMP] bottom_bar: prevent selection of hidden sheets #3831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before activating an hidden sheet had the side effect of making the sheet visible. But it made possible to activate a hidden sheet in readonly mode, since the command to un-hide the sheet was prevented. Now the allowDispatch of `ACTIVATE_SHEET` prevents activating an hidden sheet. In the bottom bar, we also now disable the menu item that unhides & activates an hidden sheet in readonly. Task: 3801883
hokolomopo
force-pushed
the
master-activate-hidden-sheet-adrm
branch
from
6e0ba43
to
3dd8c42
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 25, 2024
Before activating an hidden sheet had the side effect of making the sheet visible. But it made possible to activate a hidden sheet in readonly mode, since the command to un-hide the sheet was prevented. Now the allowDispatch of `ACTIVATE_SHEET` prevents activating an hidden sheet. In the bottom bar, we also now disable the menu item that unhides & activates an hidden sheet in readonly. closes #3831 Task: 3801883 Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before activating an hidden sheet had the side effect of making the
sheet visible. But it made possible to activate a hidden sheet in
readonly mode, since the command to un-hide the sheet was prevented.
Now the allowDispatch of
ACTIVATE_SHEETprevents activating an hiddensheet. In the bottom bar, we also now disable the menu item that
unhides & activates an hidden sheet in readonly.
Task: 3801883
Task: : 3801883
review checklist