[FW][FIX] figures: deleting a sheet will remove all figures #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets 16.0 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@VincentSchippefilt @LucasLefevre ci/runbot failed on this forward-port PR |
when deleting a sheet, we expect all the figures of that sheet to be deleted. However overrides of figures might only implement "DELETE_FIGURE". Also, implementing correctly "DELETE_SHEET" in all plugins that extends figures means that they would have to use beforeHandle to store the references of the figures of the sheet to be deleted, then in the handle do the deleting based on the saved values. It's a bit ugly. From 16.0, we need to remove the figures in the beforeHandle because the figures themselves need the sheet to still be present to be removed. opw-3783745 X-original-commit: 61ee81f
VincentSchippefilt
force-pushed
the
16.0-15-fix-delete-sheet-with-figures-vsc-Ukjz-fw
branch
from
fd280c5
to
5c59984
Compare
|
@VincentSchippefilt @LucasLefevre this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo) |
14 tasks
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 15, 2024
when deleting a sheet, we expect all the figures of that sheet to be deleted. However overrides of figures might only implement "DELETE_FIGURE". Also, implementing correctly "DELETE_SHEET" in all plugins that extends figures means that they would have to use beforeHandle to store the references of the figures of the sheet to be deleted, then in the handle do the deleting based on the saved values. It's a bit ugly. From 16.0, we need to remove the figures in the beforeHandle because the figures themselves need the sheet to still be present to be removed. opw-3783745 closes #3836 X-original-commit: 61ee81f Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
This was referenced Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
review checklist
Forward-Port-Of: #3835