[IMP] stores: add resetStores method
#3863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once the `DependencyContainer` was created and stores were injected, there was no way to remove them. It was a problem for the import of xlsx in Demo, because we created a new model and we'd want to inject a new ModelStore and re-create all the stores that had a reference to the old model. This commit creates a `resetStores` method in the `DependencyContainer` that removes all the stores. Note that references to the old stores are not removed, so we need to destroy all the components that may use store to not end up in an incorrect state.
hokolomopo
force-pushed
the
saas-17.2-fix-demo-xlsx-import-adrm
branch
from
b48e046
to
497218d
Compare
LucasLefevre
approved these changes
Mar 20, 2024
|
@hokolomopo @LucasLefevre staging failed: timed out (>50 minutes) |
|
robodoo retry |
robodoo
pushed a commit
that referenced
this pull request
Mar 21, 2024
Once the `DependencyContainer` was created and stores were injected, there was no way to remove them. It was a problem for the import of xlsx in Demo, because we created a new model and we'd want to inject a new ModelStore and re-create all the stores that had a reference to the old model. This commit creates a `resetStores` method in the `DependencyContainer` that removes all the stores. Note that references to the old stores are not removed, so we need to destroy all the components that may use store to not end up in an incorrect state. closes #3863 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Once the
DependencyContainerwas created and stores were injected, there was no way to remove them. It was a problem for the import of xlsx in Demo, because we created a new model and we'd want to inject a new ModelStore and re-create all the stores that had a reference to the old model.This commit creates a
resetStoresmethod in theDependencyContainerthat removes all the stores. Note that references to the old stores are not removed, so we need to destroy all the components that may use store to not end up in an incorrect state.review checklist