[FW][FIX] Composer: weird behavior of autocomplete dropdown #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when users typed "=S" in the composer, clicked outside, then
started editing another cell, the autocomplete dropdown remained visible.
Similarly, when they typed "=SUM(" and pressed enter, then edited another
cell, the function assistant persisted.
This commit addresses the problem by ensuring that state values are set
to false whenever the composer is not in edit mode.
Taskid: 3789473
X-original-commit: f4e0d71
|
This PR targets saas-16.3 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@dhrp-odoo @rrahir the next pull request (#3867) is in conflict. You can merge the chain up to here by saying
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 21, 2024
Previously, when users typed "=S" in the composer, clicked outside, then
started editing another cell, the autocomplete dropdown remained visible.
Similarly, when they typed "=SUM(" and pressed enter, then edited another
cell, the function assistant persisted.
This commit addresses the problem by ensuring that state values are set
to false whenever the composer is not in edit mode.
closes #3866
Taskid: 3789473
X-original-commit: f4e0d71
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Dhrutik Patel (dhrp) <dhrp@odoo.com>
fw-bot
deleted the
saas-16.3-16.0-fix-autocomplete-weird-behavior-dhrp-Ima4-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously, when users typed "=S" in the composer, clicked outside, then started editing another cell, the autocomplete dropdown remained visible. Similarly, when they typed "=SUM(" and pressed enter, then edited another cell, the function assistant persisted.
This PR addresses the problem by ensuring that state values are set to false whenever the composer is not in edit mode.
Task: : 3789473
review checklist
Forward-Port-Of: #3834