Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] Composer: weird behavior of autocomplete dropdown #3868

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Mar 21, 2024

Description:

Previously, when users typed "=S" in the composer, clicked outside, then started editing another cell, the autocomplete dropdown remained visible. Similarly, when they typed "=SUM(" and pressed enter, then edited another cell, the function assistant persisted.

This PR addresses the problem by ensuring that state values are set to false whenever the composer is not in edit mode.

Task: : 3789473

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3867
Forward-Port-Of: #3834

@robodoo
Copy link
Collaborator

robodoo commented Mar 21, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Mar 21, 2024

@dhrp-odoo @rrahir cherrypicking of pull request #3834 failed.

stdout:

Auto-merging src/components/composer/composer/composer.ts
CONFLICT (content): Merge conflict in src/components/composer/composer/composer.ts
Auto-merging tests/composer/autocomplete_dropdown_component.test.ts
CONFLICT (content): Merge conflict in tests/composer/autocomplete_dropdown_component.test.ts

stderr:

13:16:26.272408 git.c:463               trace: built-in: git cherry-pick b9209d41eb7fdb3edcda723946535cc5d4500980
error: could not apply b9209d41e... [FIX] Composer: weird behavior of autocomplete dropdown
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Previously, when users typed "=S" in the composer, clicked outside, then
started editing another cell, the autocomplete dropdown remained visible.
Similarly, when they typed "=SUM(" and pressed enter, then edited another
cell, the function assistant persisted.

This commit addresses the problem by ensuring that state values are set
to false whenever the composer is not in edit mode.

Taskid: 3789473
X-original-commit: 3054eb7
@dhrp-odoo dhrp-odoo force-pushed the 17.0-16.0-fix-autocomplete-weird-behavior-dhrp-urqC-fw branch from bedb91b to 9f61761 Compare March 22, 2024 06:46
@dhrp-odoo
Copy link
Contributor

@rrahir, Conflicts resolved! ✅

@rrahir
Copy link
Collaborator

rrahir commented Mar 22, 2024

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants