Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][REM] filters: remove green headers with data filters #3888

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Mar 22, 2024

Description

This commit removes the green headers that were used to indicate that a column/row had a data filter applied to it. The feature wasn't very useful at the introduction of data filters, and is now even more strange and useless with the introduction of Tables.

Task: : 3815440

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3859

This commit removes the green headers that were used to indicate that a
column/row had a data filter applied to it. The feature wasn't very
useful at the introduction of data filters, and is now even more
strange and useless with the introduction of Tables.

Task: 3815440
X-original-commit: 172e2ed
@robodoo
Copy link
Collaborator

robodoo commented Mar 22, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Mar 22, 2024

@hokolomopo @LucasLefevre this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@LucasLefevre
Copy link
Collaborator

fw-bot r+

robodoo pushed a commit that referenced this pull request Mar 22, 2024
This commit removes the green headers that were used to indicate that a
column/row had a data filter applied to it. The feature wasn't very
useful at the introduction of data filters, and is now even more
strange and useless with the introduction of Tables.

closes #3888

Task: 3815440
X-original-commit: 172e2ed
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo closed this Mar 22, 2024
@robodoo robodoo added the 17.3 label Mar 22, 2024
@fw-bot fw-bot deleted the master-master-remove-green-headers-adrm-49xZ-fw branch April 5, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants