[IMP] plugins: remove unused getters #3892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the library evolved, some getters that were created for specific purpose became completely obsolete (sometimes the features evolved and theyr were replaces by better alternatives, sometimes, due to a conceptual evolution, like a finer split between plugins responsibilities). Some of those getters were not removed at the time and can be safely removed. Task: 3825311
rrahir
changed the title
rrahir
force-pushed
the
master-purge-unued-rar
branch
from
6f2bb4a
to
6e2cbc7
Compare
robodoo
pushed a commit
that referenced
this pull request
Mar 25, 2024
As the library evolved, some getters that were created for specific purpose became completely obsolete (sometimes the features evolved and theyr were replaces by better alternatives, sometimes, due to a conceptual evolution, like a finer split between plugins responsibilities). Some of those getters were not removed at the time and can be safely removed. closes #3892 Task: 3825311 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the library evolved, some getters that were created for specific purpose became completely obsolete (sometimes the features evolved and theyr were replaces by better alternatives, sometimes, due to a conceptual evolution, like a finer split between plugins responsibilities). Some of those getters were not removed at the time and can be safely removed.
Task: 3825311
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist