Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] SplitIntoColumnsPanel: Panel closes instantly #3930

Closed
wants to merge 1 commit into from

Conversation

rrahir
Copy link
Collaborator

@rrahir rrahir commented Mar 26, 2024

There was a mistake in the code adaptation when we introduced the stores.

How to reproduce:

  • Open a spreadsheet
  • Open "Topbar menu > Split text to columns" -> The sidepanel opens and closes instantly

Task: 3829192

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

There was a mistake in the code adaptation when we introduced the
stores.

How to reproduce:
- Open a spreadsheet
- Open "Topbar menu > Split text to columns"
-> The sidepanel opens and closes instantly

Task: 3829192
@robodoo
Copy link
Collaborator

robodoo commented Mar 26, 2024

Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Mar 28, 2024
There was a mistake in the code adaptation when we introduced the
stores.

How to reproduce:
- Open a spreadsheet
- Open "Topbar menu > Split text to columns"
-> The sidepanel opens and closes instantly

closes #3930

Task: 3829192
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo closed this Mar 28, 2024
@fw-bot fw-bot deleted the saas-17.2-fix-split-text-panel-rar branch April 11, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants