[FW][FIX] chart: preserve label order when aggregate #3964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the labels were not preserving their order when data was aggregated. This was due to the labels being stored in an object, whose order is not guaranteed. This commit addresses the issue by returning a labelSet and mapping the data accordingly. Taskid: 3834222 X-original-commit: 9961402
|
This PR targets saas-16.4 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@dhrp-odoo @LucasLefevre the next pull request (#3965) is in conflict. You can merge the chain up to here by saying
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 3, 2024
Previously, the labels were not preserving their order when data was aggregated. This was due to the labels being stored in an object, whose order is not guaranteed. This commit addresses the issue by returning a labelSet and mapping the data accordingly. closes #3964 Taskid: 3834222 X-original-commit: 9961402 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Dhrutik Patel (dhrp) <dhrp@odoo.com>
fw-bot
deleted the
saas-16.4-saas-16.3-fix-aggregate-sort-the-labels-dhrp-fwQU-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously, the labels were not preserving their order when data was aggregated. This was due to the labels being stored in an object, whose order is not guaranteed. This PR addresses the issue by returning a labelSet and mapping the data accordingly.
Task: : 3834222
review checklist
Forward-Port-Of: #3948