Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] evaluation: fix function name interpolation in errors #3966

Closed

Conversation

LucasLefevre
Copy link
Collaborator

@LucasLefevre LucasLefevre commented Apr 2, 2024

Description:

Write a VLOOKUP function that doesn't match anything such that it returns #N/A 

=> look at the error message, it contains [[FUNCTION_NAME]] instead of VLOOKUP

Task: : 3839097

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@LucasLefevre LucasLefevre mentioned this pull request Apr 2, 2024
Closed
14 tasks
@robodoo
Copy link
Collaborator

robodoo commented Apr 2, 2024

Write a VLOOKUP function that doesn't match anything such that it returns #N/A 

=> look at the error message, it contains [[FUNCTION_NAME]] instead of VLOOKUP

Task: 3839097
@LucasLefevre LucasLefevre force-pushed the saas-17.1-function-name-placeholder-lul branch from 595a8e3 to 3474f63 Compare April 2, 2024 14:06
@rrahir
Copy link
Collaborator

rrahir commented Apr 11, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 11, 2024
Write a VLOOKUP function that doesn't match anything such that it returns #N/A 

=> look at the error message, it contains [[FUNCTION_NAME]] instead of VLOOKUP

closes #3966

Task: 3839097
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
@robodoo robodoo closed this Apr 11, 2024
@fw-bot fw-bot deleted the saas-17.1-function-name-placeholder-lul branch April 25, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants