Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FW][FIX] sheetview: pageUp/Down with frozen rows #4046

Closed
wants to merge 1 commit into from
Closed

[FW][FIX] sheetview: pageUp/Down with frozen rows #4046

wants to merge 1 commit into from

Commits on Apr 11, 2024

  1. [FIX] sheetview: pageUp/Down with frozen rows 

    There was two issues with the commands `SHIFT_VIEWPORT_UP/DOWN` when
some rows were frozen:

- the viewport was never scrolled all the way down to the last row
with pageDown
- pageDown/Up scrolled more than a "page" (the size of the viewport)

This commit fixes both issues.

Also replaced calls from `getActiveMainViewport` to `getMainInternalViewport`
in the plugin `SheetView` as it needs slightly less computations.

Task: 3847414
X-original-commit: ff481da
    @hokolomopo
    hokolomopo committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    a8a8458 View commit details
    Browse the repository at this point in the history