Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] icons: replace custom icons by font-awesome icons #4051

Closed
wants to merge 1 commit into from
Closed

[REF] icons: replace custom icons by font-awesome icons #4051

wants to merge 1 commit into from

Conversation

hokolomopo
Copy link
Contributor

Description

With the introduction of font awesome in o-spreadsheet, we can replace some custom SVGs by native font awesome icons.

Task: : 3863616

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Apr 11, 2024

Pull request status dashboard.

@hokolomopo hokolomopo force-pushed the master-font-aweome-icons-replace-ardm branch 3 times, most recently from b1f2866 to 05e1d06 Compare April 16, 2024 08:13
@hokolomopo
[REF] icons: replace custom icons by font-awesome icons
2b9a8cf 
With the introduction of font awesome in o-spreadsheet, we can replace
some custom SVGs by native font awesome icons.

Task: 3863616
@hokolomopo hokolomopo force-pushed the master-font-aweome-icons-replace-ardm branch from 05e1d06 to 2b9a8cf Compare April 17, 2024 06:29
LucasLefevre
LucasLefevre approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Apr 18, 2024
@hokolomopo
[REF] icons: replace custom icons by font-awesome icons
a378f84 
With the introduction of font awesome in o-spreadsheet, we can replace
some custom SVGs by native font awesome icons.

closes #4051

Task: 3863616
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo closed this Apr 18, 2024
@robodoo robodoo added the 17.3 label Apr 18, 2024
@fw-bot fw-bot deleted the master-font-aweome-icons-replace-ardm branch May 2, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasLefevre LucasLefevre LucasLefevre approved these changes

Assignees
No one assigned
Labels
17.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hokolomopo @robodoo @LucasLefevre