Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] pivot: do not delay update by default #4304

Closed
wants to merge 1 commit into from

Conversation

pro-odoo
Copy link
Collaborator

Before this commit, the pivot definition was updated only after the user clicked on the "Update" button. This could be confusing for the user, as the pivot definition was not updated when the user changed the pivot configuration.

Task: 3953753

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented May 30, 2024

@pro-odoo pro-odoo force-pushed the master-defer-update-later-pro branch from e314e7e to a0c420d Compare June 5, 2024 06:41
Before this commit, the pivot definition was updated only after the
user clicked on the "Update" button. This could be confusing for the
user, as the pivot definition was not updated when the user changed
the pivot configuration.

Task: 3953753
@pro-odoo pro-odoo force-pushed the master-defer-update-later-pro branch from a0c420d to 2fe6831 Compare June 10, 2024 10:22
@rrahir
Copy link
Collaborator

rrahir commented Jun 11, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request Jun 11, 2024
Before this commit, the pivot definition was updated only after the
user clicked on the "Update" button. This could be confusing for the
user, as the pivot definition was not updated when the user changed
the pivot configuration.

closes #4304

Task: 3953753
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
@robodoo robodoo closed this Jun 11, 2024
@robodoo robodoo added the 17.4 label Jun 11, 2024
@fw-bot fw-bot deleted the master-defer-update-later-pro branch June 25, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants