Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] charts: truncate labels by default #4596

Closed
wants to merge 1 commit into from
Closed

[FIX] charts: truncate labels by default #4596

wants to merge 1 commit into from

Conversation

dhrp-odoo
Copy link
Contributor

Description

This PR ensures that labels are truncated by default in charts. The truncation can be disabled by passing the truncate option to the chart configuration.

Task: : 3958962

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@dhrp-odoo
[FIX] charts: truncate labels by default
e045ca7 
This commit ensures that labels are truncated by default in charts.
The truncation can be disabled by passing the `truncate` option to
the chart configuration.

Task: 3958962
@robodoo
Copy link
Collaborator

robodoo commented Jul 4, 2024

Pull request status dashboard

LucasLefevre
LucasLefevre approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+
thanks :)

robodoo pushed a commit that referenced this pull request Jul 10, 2024
@dhrp-odoo
[FIX] charts: truncate labels by default
e990ea2 
This commit ensures that labels are truncated by default in charts.
The truncation can be disabled by passing the `truncate` option to
the chart configuration.

closes #4596

Task: 3958962
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@fw-bot fw-bot mentioned this pull request Jul 10, 2024
Closed
14 tasks
@robodoo robodoo closed this Jul 10, 2024
This was referenced Jul 10, 2024
Closed
Closed
Closed
@fw-bot fw-bot deleted the 17.0-fix-truncate-labels-by-default-dhrp branch July 24, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasLefevre LucasLefevre LucasLefevre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhrp-odoo @robodoo @LucasLefevre