[FIX] tools: empty name

Check if name isn't empty before executing regex. xlsxwriter can handle an empty name. opw-769163 Closes #18877
odoo · Aug 31, 2017 · 0fff391 · 0fff391
1 parent 65f5fc6
commit 0fff391
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/odoo/tools/misc.py b/odoo/tools/misc.py
@@ -372,11 +372,12 @@ class PatchedXlsxWorkbook(xlsxwriter.Workbook):
 
         # TODO when xlsxwriter bump to 0.9.8, add worksheet_class=None parameter instead of kw
         def add_worksheet(self, name=None, **kw):
-            # invalid Excel character: []:*?/\
+            if name:
-            name = re.sub(r'[\[\]:*?/\\]', '', name)
+                # invalid Excel character: []:*?/\
+                name = re.sub(r'[\[\]:*?/\\]', '', name)
 
-            # maximum size is 31 characters
+                # maximum size is 31 characters
-            name = name[:31]
+                name = name[:31]
             return super(PatchedXlsxWorkbook, self).add_worksheet(name, **kw)
 
     xlsxwriter.Workbook = PatchedXlsxWorkbook