Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web editor should keep non-breaking space in website #24810

Open
zeroheure opened this issue May 18, 2018 · 5 comments
Open

web editor should keep non-breaking space in website #24810

zeroheure opened this issue May 18, 2018 · 5 comments
Labels
9.0 10.0 11.0 13.0 Framework General frontend/backend framework issues

Comments

@zeroheure
Copy link
Contributor

zeroheure commented May 18, 2018

Impacted versions:
8, 9, 10, 11

Steps to reproduce:
Choose a long text on your website. At the end of a line, add a non-breaking space before a ponctuation sign (or a word), does it with your keyboard, not with an html entity. Resize the box or the window.

Current behavior:
The ponctuation sign goes at the beginning of the next line. Non-breaking space is replaced. User quickly shout at technical guys or throw the computer through the window !
Code is in /web_editor/static/src/js/rte.summernote.js, look for var exp2 = /(?!([ ]|\u00A0)|^)\u00A0(?!([ ]|\u00A0)|$)/g; (\u00A0 is non-breaking space unicode value).

Expected behavior:
Keep non-breaking space ! allow users to have beautiful and readable text on website ! help tech guys to have a nice day!

@JKE-be JKE-be added Framework General frontend/backend framework issues and removed Website labels Nov 21, 2018
@zeroheure
Copy link
Contributor Author

up
AFAIK, this is still the case in current Odoo 13 (tested).

@Yenthe666 Yenthe666 added the 13.0 label Nov 24, 2019
@zeroheure
Copy link
Contributor Author

Still the case on Odoo 14, 15 and 15.1 tested on runbot

@zeroheure
Copy link
Contributor Author

ping

@qsm-odoo
Copy link
Contributor

qsm-odoo commented Jun 7, 2022

Hello,

Sorry for having forgotten about this issue. Starting from 15.0, summernote is gone so if the issue is still there this cannot be because of the same code. I tried to reproduce the issue you described both before and after 15.0 (I tried master and 14.0) but my non breaking spaces seem to be kept in both versions. Could you maybe a video of your issue or more exact steps so we can consider the issue?

I'll ping @dmo-odoo who can better handle text editor issues (at least for the 15.0 and above issues) and redirect to the right person if necessary 👍

@qsm-odoo qsm-odoo removed their assignment Jun 7, 2022
@dmo-odoo
Copy link
Contributor

dmo-odoo commented Jun 8, 2022

Thanks for taking the time to report an issue. For Odoo 15 and above, non-breaking spaces are supposed to be preserved. If you notice a situation where they aren't, then I'd be interested to see a video that shows how to reproduce the issue on a 15.0 runbot so that we can work on isolating the issue and fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.0 10.0 11.0 13.0 Framework General frontend/backend framework issues
Projects
None yet
Development

No branches or pull requests

5 participants