Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vietnamese Thousands Separator Error #2545

Closed
leotran opened this issue Sep 19, 2014 · 5 comments
Closed

Vietnamese Thousands Separator Error #2545

leotran opened this issue Sep 19, 2014 · 5 comments

Comments

@leotran
Copy link

leotran commented Sep 19, 2014

After config Decimal Accuracy for Product Price is 0. I enter Unit Price on Product or Quotation form, ex: 80.000. It become 80 when it saved. If Decimal Accuracy for Product Price is not equa 0 (ex: 2), it's work!
selection_001

selection_002

@vulehd
Copy link

vulehd commented Sep 25, 2014

You should input 80,000 or 80000.

@davidtranhp
Copy link
Contributor

inputting 80,000 for eighty thousand is not native to Vietnamese language. It's US style!
The correct and native behaviour should be 80.000 for eighty thousand. That's why Leo Tran said it's a kind of bug.
AFAIK, some European countries also have the same style as Vietnam's one. Eighty Thousand should be 80.000 instead of 80,000.

@Adoniasv
Copy link

Is a Bug.

Change this file:

addons/web/static/js/formats.js

Find this line in function instance.web.parse_value:

  case 'float':          
     tmp = Number(value); 
     if (!isNaN(tmp))
        return tmp; 

and change for this (Coment whit //)

 case 'float':          
     //tmp = Number(value); 
     //if (!isNaN(tmp))
        //return tmp; 

is working for us

@mart-e
Copy link
Contributor

mart-e commented Dec 20, 2016

Hello,

Is it still the case? The decimal separator is specified on the language and it can be accepted on a pull request if a change is needed.

@Yenthe666
Copy link
Collaborator

Hi @leotran,

Thank you for your bug report.
At this point Odoo 8 is no longer supported as Odoo only supports three versions (9.0, 10.0, 11.0 at the moment).
If you can still reproduce this issue on Odoo 9, Odoo 10 or Odoo 11 we encourage you to create a new bug report.

Regards,
Yenthe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants