Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] Purchase: Do not add lines from same PO multiple times on the Vendor Bill #50026

Open
sswapnesh opened this issue Apr 22, 2020 · 5 comments
Labels
13.0 Confirmed the bug was confirmed by testers Logistics about stock, mrp, delivery, purchase

Comments

@sswapnesh
Copy link
Contributor

Impacted versions: 13.0

Steps to reproduce:

  • Select PO on Vendor Bills (It add new Line in Invoice Lines)
  • Select Same PO Reference

Current behavior: It adds Same lines multiple times
screenshot-2330034-13-0-acd1ee runbot44 odoo com-2020 04 22-22_22_12

Expected behavior: Same as v12 where Lines were not duplicated

Video/Screenshot link (optional):

@pedrobaeza
Copy link
Collaborator

This would be purchase, not account. I think this is done on purpose for allowing you to repeat data if you want.

@sswapnesh sswapnesh changed the title [13.0] account: Do not add lines from same PO multiple times [13.0] Purchase: Do not add lines from same PO multiple times on the Vendor Bill Apr 22, 2020
@sswapnesh
Copy link
Contributor Author

@pedrobaeza Title Updated. Not sure and I could not find the Detailed PR message about this one

Maybe some regression as it is pointing to purchase.bill.union not purchase.order

@pedrobaeza
Copy link
Collaborator

That's because now it allows to select an old invoice or a pending purchase, but that "pending" thing is relative.

@nhomar
Copy link
Collaborator

nhomar commented Apr 27, 2020

@pedrobaeza I think this is a mistake, it is an error, see the behavior only happen in a very specific situation (video with the PoC).

Why do I think it is a mistake?

  1. It does not behave in the same way when quantities are the same as the Po.
  2. it is only when no shipping done at least on my example.
  3. it is ignored (the second time I used the same PO) as it should do.

I think it is a combination of steps that are doing the bug, related with the messy onchange stuff.

Thanks for your bug report @sswapnesh

@nhomar nhomar added the Confirmed the bug was confirmed by testers label Apr 27, 2020
@pedrobaeza pedrobaeza added 13.0 Logistics about stock, mrp, delivery, purchase labels Apr 27, 2020
@pedrobaeza
Copy link
Collaborator

OK, then let's put all tags and wait for an answer from the corresponding team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13.0 Confirmed the bug was confirmed by testers Logistics about stock, mrp, delivery, purchase
Projects
None yet
Development

No branches or pull requests

3 participants