-
Notifications
You must be signed in to change notification settings - Fork 23.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible to create products with duplicate serial numbers. #54472
Comments
I don't see instructions enough detailed for reproducing the problem. What do you mean by "Complete a MO"? Please record a video showcasing the problem. |
Original description updated for clarity. I will endeavor to post a video when I can. |
Video showcasing the issue. The same serial number, in this case TEST01 can be continually used in manufacture and 'installed' in multiple manufacturing orders. |
OK, thanks for the video. I see the potential problem, although not sure if this can be prevented the way serial numbers work, as the control is quantity per physical locations, and as you have already consumed the other raw material, the quantity is in the virtual location "Production". @amoyaux @sle-odoo maybe something to take into account for manufacturing ? |
Thanks for taking time to view it! The same duplication can occur if you produce product "Serialized Parent Product" with a serial number and transfer to a different location (even a physical one), you could then produce another "Serialized Parent Product" with the same serial number as the first. In fact, the duplication can occur by simply completing Inventory Adjustments at any two locations, the same serial number can be used for both. Given the above, it must only be checking the finish location of the current operation, not necessarily limited to physical locations. I will endeavor to record another video and find some code snippets. When I get an opportunity I will look into possible solutions and their implications, as this issue has some serious consequences, namely traceability, warranty and recall of products, not to mention the cost of producing duplicate serial numbers and the potential rework involved when it is discovered. |
Impacted versions: 12.0, 13.0
Steps to reproduce:
Product Type - Storable Product
Tracking - By Unique Serial Number
Routes - Manufacture
Current behavior:
Product can have the same serial number on multiple instances of the component (as shown in screenshot below). This can also occur if the product is in a different location than the location the product is being manufactured (i.e. picking, packing). In this case, the serial number is only validated when the product is being moved into a location where there is a duplicate serial number (by this time it is too late, and the product has already been manufactured/serialized).
Expected behavior:
Validation Error "A serial number should only be linked to a single product" should be thrown when trying to create the child product during it's MO, as the serialized product already exists, it's just installed in another product (or potentially moved to another location).
Video/Screenshot link (optional):
The text was updated successfully, but these errors were encountered: