Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoS popups buttons are not translatable #69284

Open
mhabboush97 opened this issue Apr 15, 2021 · 3 comments
Open

PoS popups buttons are not translatable #69284

mhabboush97 opened this issue Apr 15, 2021 · 3 comments
Assignees

Comments

@mhabboush97
Copy link

Impacted versions:
14, maybe others
Steps to reproduce:
in PoS awaitable popups, the default button text is plain string, without _t, so this make translating button impossible for popups that are shown in code and uses default popup button text
https://github.com/odoo/odoo/tree/14.0/addons/point_of_sale/static/src/js/Popups
for example

ConfirmPopup.defaultProps = {
confirmText: 'Ok',
cancelText: 'Cancel',
title: 'Confirm ?',
body: '',
};

const { confirmed } = await this.showPopup('ConfirmPopup', {
title: this.env._t('Please select the Customer'),
body: this.env._t(
'You need to select the customer before you can invoice an order.'
),
});

and so on
Current behavior:

Expected behavior:

Video/Screenshot link (optional):

Support ticket number submitted via odoo.com/help (optional):

@mhabboush97
Copy link
Author

@pimodoo any thoughts of fixing it?

@mhabboush97
Copy link
Author

@pimodoo
another case of this issue

const { confirmed } = await this.showPopup('ConfirmPopup', {
title: 'Existing orderlines',
body: `${order.name} has total amount of ${this.getTotal(
order
)}, are you sure you want delete this order?`,
});

@Yenthe666
Copy link
Collaborator

#70000 seems to also fix some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants