[13.0] base_vat: Cleaning only happens if you introduce the country code in the VAT

[pedrobaeza]

Impacted versions: 13.0

Steps to reproduce:

• Create a contact.
• Set Spain as country.
• Put VAT 05680675-C

Current behavior:

The VAT is validated, but stored as is (05680675-C).

Expected behavior:

The VAT is validated, and stored as 05680675C, or even better, stored as ES05680675C.

The explanation is in this line of code:

odoo/addons/base_vat/models/res_partner.py

Line 502 in a93a0a3

if code and code.lower() != vat_country:

where there's no cleaning if no country code is found on the VAT.

I think we should normalize the VAT input to be homogeneous (with the country code), the same we do with the phone numbers, or if not, we may have a contact with 05680675C and another ES05680675C, and not being detected as duplicated VAT number.

[pedrobaeza]

@oco-odoo I think you can be the more suitable to talk about this, as you have recently do all the work for assuring the verification.

@mart-e also worked if I don't remember bad on allowing to not needing the country prefix in their moment.

[oco-odoo]

@pedrobaeza Sorry for the late answer. I agree VAT check could be improved. We discussed it with @tsb-odoo , and added your feedback to the list of things to consider when improving that :) It will be for master, though, as we don't want to break any flow depending on the current behavior (even if it's not perfect).

[pedrobaeza]

Yeah, I suppose that this kind of thing is not the best for stable versions, but at least if you include it on master is a great thing for homogenizing this and not having more side effects.

[pedrobaeza]

@oco-odoo any news about this?

[oco-odoo]

@pedrobaeza Not yet. Still in the list of things to consider.