Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master][14.0][13.0] [REGRESSION] "Label" instead of (product) "Description" on invoices #75420

Open
primes2h opened this issue Aug 22, 2021 · 8 comments

Comments

@primes2h
Copy link
Contributor

Impacted versions:

master, 14.0, 13.0

Steps to reproduce:

Create an invoice, add a line, select a product.

Current behavior:

Product description column is named "Label".

image

This is a regression.
In any other documents (RFQ, PO, SO, etc.) (all versions) and invoices (v.12.0), the column is correctly named "Description".

image

image

image

Expected behavior:

Product description column must be named "Description".

@pedrobaeza
Copy link
Collaborator

I personally don't consider that a regression, as now the invoice is a journal entry, and the popup form is a general form view for journal items. Being an understandable label similar to description, creating an specific view for that and all the needed stuff for showing it, it's oversized for the benefit.

Anyways, I let others to give their opinion.

@primes2h
Copy link
Contributor Author

primes2h commented Aug 23, 2021

I personally don't consider that a regression, as now the invoice is a journal entry, and the popup form is a general form view for journal items. Being an understandable label similar to description,

This is the main point, It's not so clear from a user point of view IMO.

If a user wants to add a new invoice line (w/o selecting a product), he'd expect to enter a "Description of the line" not a "Label" of the line. (as it is on SO, Quotations, etc.)

immagine

creating an specific view for that and all the needed stuff for showing it, it's oversized for the benefit.

Why would you need a specific view for that?

Changing this string should be enough:

name = fields.Char(string='Label', tracking=True)

@pedrobaeza
Copy link
Collaborator

Why would you need a specific view for that?

Changing this string should be enough:

name = fields.Char(string='Label', tracking=True)

No, because that string is shared for journal items too.

@Yenthe666
Copy link
Collaborator

& changing labels in stable is generally not allowed because it breaks translations their compatibility :)

@primes2h
Copy link
Contributor Author

Why would you need a specific view for that?
Changing this string should be enough:

name = fields.Char(string='Label', tracking=True)

No, because that string is shared for journal items too.

Ok, but using "Description" for journal items too seems good to me, much better than having Label on invoice line.
What do you think?

immagine

@pedrobaeza
Copy link
Collaborator

I personally prefer the other.

@primes2h
Copy link
Contributor Author

& changing labels in stable is generally not allowed because it breaks translations their compatibility :)

Sure, but not in master branch, AFAIK. ;-)
P.S. i could open a PR if needed.

@Yenthe666
Copy link
Collaborator

Do feel free to make a PR against master, then the accounting team from Odoo can make the final call :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants