Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0, 15.0] postcommit notifications should check if email_ids still exists #76132

Open
lem8r opened this issue Sep 7, 2021 · 0 comments
Open

[14.0, 15.0] postcommit notifications should check if email_ids still exists #76132

lem8r opened this issue Sep 7, 2021 · 0 comments

Comments

@lem8r
Copy link
Contributor

lem8r commented Sep 7, 2021 •
edited

Impacted versions: 14.0

Steps to reproduce:

  1. Enable free signup.
  2. Edit partner of portal template user: assign sales person so when new user is created it will receive sales person.
  3. Sign up with login which already exists in database.

Current behavior: Odoo server error.
New user is being created as copy of portal user. Notification email is scheduled to Sales Person to notify about assignation.
Since login already exists changes are rolled back to savepoint.
Notification delivery is triggered via @self.env.cr.postcommit.add while mail message does not exists any more.

Expected behavior: sign up page shows "Another user is already registered using this email address"

Video/Screenshot link (optional):

Support ticket number submitted via odoo.com/help (optional):
@lem8r lem8r changed the title 502 when sign up with existing email and sales person is auto-assigned 500 when sign up with existing email and sales person is auto-assigned Sep 8, 2021
@lem8r lem8r changed the title 500 when sign up with existing email and sales person is auto-assigned [14.0] postcommit notifications should check if email_ids still exists Sep 8, 2021
@lem8r lem8r changed the title [14.0] postcommit notifications should check if email_ids still exists [14.0, 15.0] postcommit notifications should check if email_ids still exists Sep 9, 2021
lem8r referenced this issue Nov 8, 2021
@Xavier-Do @tde-banana-odoo
[REF] mail: simplify notification code
581a741 
Purpose of this commit is to clean notification process: calls, methods
API, method name, variable propagation.

Contains notably

  * simplify API of methods used to group recipients when sending notification
    emails;
  * improve and rename methods used in email notification process;
  * move some methods on model itself as non mail thread records could be
    mass-mailed and _notify_email_headers could be called on other records;

Related to task 1943901
Linked to PR #32404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lem8r