[13.0] GettextAlias._get_cr may choose a closed cr

[ap-wtioit]

Impacted versions:
13.0

Steps to reproduce:

if some_errors:
    with registry(self._cr.dbname).cursor() as cr:
        persist_logs(some_errors, cr)
    raise UserError(_(some_errors[0]))

Current behavior:
GettextAlias._get_cr picks the first cr found in the frame/stack

Expected behavior:
GettextAlias._get_cr picks the first unclosed cr found in the frame/stack

Video/Screenshot link (optional):

Support ticket number submitted via odoo.com/help (optional):

FYI @wt-io-it

[wtaferner]

@mart-e
What do you think?

[mart-e]

Indeed, we try to retrieve keywords like cr, context, self,.. when calling the _() method to be able to retrieve the ir.translation records.
If your cursor is closed GettextAlias will fail when using it. To fix your issue, you must open a new cursor.

For instance, when translating an error message after an SQL error, we explicitly open a new cursor.

odoo/odoo/service/model.py

Lines 76 to 84 in f62c20d

	# We open a *new* cursor here, one reason is that failed SQL
	# queries (as in IntegrityError) will invalidate the current one.
	with closing(odoo.sql_db.db_connect(dbname).cursor()) as cr:
	if ttype == 'sql_constraint':
	res = translate_sql_constraint(cr, key=key, lang=lang)
	else:
	res = translate(cr, name=False, source_type=ttype,
	lang=lang, source=src)
	return res or src

raise UserError(_(some_errors[0]))

This won't work by the way, you should only pass static strings to _() if you want the export to work.