[FIX] get login_number in the same transaction as update it #24486
Conversation
|
@pimodoo it's related to POS |
|
cc @blaggacao |
|
Hello, we were able to reproduce the issue, by connecting the session at exact same time, we then tried to apply you PR, and face an issue, showing undefined value in the POS order number, cf: attached imaged |
|
@pimodoo are you sure that you restarted odoo after applying the update? |
|
@yelizariev I'll recheck, I think I didn't update the module so the template didn't have the login value. |
|
I think I already saw this happen when two people used the PoS with the same account on different computers (which is a bad idea, let's be clear !). |
|
@mart-e it's master branch. Do we need someone's approvement? |
|
Can this be merged? |
mart-e
force-pushed
the
12.0-pos-fix-login_number
branch
from
024a591
to
526e1d2
Compare
|
Status? |
mart-e
force-pushed
the
12.0-pos-fix-login_number
branch
from
526e1d2
to
37d8497
Compare
…te it Otherwise, if two POS stations are using the same user with the same pos.config, i.e. create two session AND if you have bad luck, then those sessions will get same login_number, which leads to losing half of orders, because POS stations will generate same pos_reference and only first order from the POSes is saved, while another order is lost without let know to cashier.
mart-e
force-pushed
the
12.0-pos-fix-login_number
branch
from
37d8497
to
44d2ab6
Compare
|
I was going to merge this but I am not sure this is still reproducible in saas-12.5. |
|
@mart-e The problem is still there, you can merge it |
|
Thanks for the update |
…te it Otherwise, if two POS stations are using the same user with the same pos.config, i.e. create two session AND if you have bad luck, then those sessions will get same login_number, which leads to losing half of orders, because POS stations will generate same pos_reference and only first order from the POSes is saved, while another order is lost without let know to cashier. closes #24486 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
|
Merged at c0a897d, thanks! |
Description of the issue/feature this PR addresses:
if you have two POS stations, that use same user, same
pos.config,i.e. create two sessions AND if you have bad luck, then those sessions will get
same login_number, which leads to losing half of the orders, because of POS stations
will generate the same
pos_referenceand only first order from the POSes is saved,while another order is lost without let know to the cashier.
Current behavior before PR:
orders are lost
Desired behavior after PR is merged:
Be sure that login_number is not shared with another POS
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
@it-projects-llc