[ADD] base: add Arabic languge #28640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May be better to add in master this csv will be loaded when someone upgrade |
|
Well as odoo finally works well with Arabic languages, it is the right time to have a proper Arabic language. |
mart-e
force-pushed
the
12.0-arabic-language-code-mat
branch
from
7666ea5
to
224fda1
Compare
|
robodoo r+ |
mart-e
force-pushed
the
12.0-arabic-language-code-mat
branch
from
224fda1
to
f900b70
Compare
mart-e
force-pushed
the
12.0-arabic-language-code-mat
branch
from
f900b70
to
13c200d
Compare
odony
reviewed
Feb 18, 2019
| @@ -1,8 +1,10 @@ | |||
| "id","name","code","iso_code","direction","grouping","decimal_point","thousands_sep","date_format","time_format","translatable","week_start" | |||
| "base.lang_en","English","en_US","en","Left-to-Right","[3,0]",".",",","%m/%d/%Y","%H:%M:%S","True","7" | |||
| "base.lang_am_ET","Amharic / አምሃርኛ","am_ET","am_ET","Left-to-Right","[3,0]",".",",","%d/%m/%Y","%I:%M:%S","True","7" | |||
| "base.lang_ar_SY","Arabic / الْعَرَبيّة","ar_SY","ar","Right-to-Left","[3,0]",".",",","%d %b, %Y","%I:%M:%S","True","6" | |||
There was a problem hiding this comment.
Let's use ar_AA (Arabic "Unitag") as a countryless ISO code for arabic :-)
Now that we have proper support for RTL language, add an Arabic language with code "ar" (while the only possiblity before was ar_SY). Use ar_AA code as Arabic unitag. In master, the ar_SY could be removed as no need to have both. Add Bengali language Fixes odoo#31165
mart-e
force-pushed
the
12.0-arabic-language-code-mat
branch
from
13c200d
to
89dabeb
Compare
robodoo
added
CI 🤖
|
robodoo r+ |
|
Merged, thanks! |
|
odoo/odoo/addons/base/models/res_lang.py Line 52 in 491deeb Actually works because loading of csv files update existing row before creating new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Odoo only has
ar_SYlanguage but not a generic Arabic language.cc @odony to be sure it is a stable change