Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] stock: don't show validate if no move_lines #29912

Closed
wants to merge 1 commit into from
Closed

[FIX] stock: don't show validate if no move_lines #29912

wants to merge 1 commit into from

Conversation

fmdl
Copy link
Contributor

@fmdl fmdl commented Jan 3, 2019

Description of the issue/feature this PR addresses:
Go to inventory
Create a picking
Save
--> you see the validate button --> it doesn't make sens because there no move_lines.

Note : apply the same behavior than the mark_as_todo button.

@nim-odoo

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added seen 🙂 CI 🤖 Robodoo has seen passing statuses labels Jan 3, 2019
@fmdl
Copy link
Contributor Author

fmdl commented Jan 11, 2019

@sle-odoo

@fmdl
Copy link
Contributor Author

fmdl commented Jan 23, 2019

OPW 1 932 184

@fmdl fmdl changed the base branch from 11.0 to master January 24, 2019 07:27
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Jan 24, 2019
@fmdl
Copy link
Contributor Author

fmdl commented Jan 24, 2019

@nim-odoo updated to master

@nim-odoo nim-odoo requested a review from Whenrow January 25, 2019 14:47
@Whenrow
Copy link
Contributor

Whenrow commented Jan 25, 2019

There is already an error message to deal that : 85c5bf0#diff-998d1e77af0fdebafa3c662492abe33cR715.

The depend on immediate_transfer is useless as it's set at the creation and never change

The depend on move_lines will be triggered many times. Why not complete the domain in the view with ('move_lines', '=', False) ?

@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jan 25, 2019
@fmdl
Copy link
Contributor Author

fmdl commented Jan 26, 2019

@Whenrow I have remove immediat_transfert

@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Jan 26, 2019
@fmdl
Copy link
Contributor Author

fmdl commented Mar 21, 2019

@Whenrow any news, thanks.

@C3POdoo C3POdoo added the Logistics about stock, mrp, delivery, purchase label Dec 31, 2019
@fmdl fmdl closed this Jan 8, 2020
@robodoo robodoo added closed 💔 and removed CI 🤖 Robodoo has seen passing statuses labels Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Whenrow Whenrow Awaiting requested review from Whenrow

Assignees
No one assigned
Labels
Logistics about stock, mrp, delivery, purchase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fmdl @Whenrow @C3POdoo @robodoo