[FIX] web: no chrome autocompete on many2one widget

[nle-odoo]

For editing many2one fields (and partially many2many) most widget show
an autocompleting list of targeted records.

They thus have autocomplete="off" to prevent browser completion.

But chromium has an history of breaking autocomplete="off", see:

• https://caniuse.com/#search=autocomplete
• https://crbug.com/468153
• https://crbug.com/587466
• https://crbug.com/914451

It seems that recently (chromium 71 at least), the heuristic to ignore
autocomplete="off" has become more aggressive and for example on
Many2one with placeholder "Country", chromium will display browser
autocomplete:

• hidding the many2one autocomplete
• having field empty when visually filled if the autocomplete result is
  selected.

With this changeset, the placeholder in the many2one instance is
interspersed with U+FEFF charcters (ZERO WIDTH NO-BREAK SPACE) so the
browser does enable the autocomplete feature by force.

This should thus remove the issue (until it is fixed by chromium) in the
case of field named "Country" or matching other regexes in this file:

https://github.com/chromium/chromium/blob/cdb1b2073f12/components/autofill/core/common/autofill_regex_constants.cc

U+FEFF has been chosen instead of more recommended characters because
other have been shown erroneous for printing in some windows
configuration (see cb2a3af).

[nle-odoo]

I worked on a first solution: a6e71b7f4e53 that removed/added back the placeholder when the many2one autocomplete was opened/closed.

But there was side effects (the placeholder is removed at first click, the browser autocomplete is shown the first time until something is written in the input, ...).

The new solution is more simple and seem to work well but there is downside such as: someone selecting input[placeholder="Country"] in CSS or javascript, and I don't know how screen reader would react.

[len-foss]

Thank you nle and thanks to our great overlords at Google. May our prayers reach them.

[nle-odoo]

@KangOl here the solution is rather hackish (the fix should be merged in 10.0)

do you think this is alright to do this?

this may be solved at one point by chromium and this could be reverted in Odoo but currently the issue breaks functionality in google chrome of some many2one widgets (Country and State for example)

[KangOl]

I propose to forbid using chrome and ask people to install firefox.

[KangOl]

Can you please link to this PR in code comment?

[nle-odoo]

I added , see #30439 and did PR for 10.0 with same code #30449

[Elkasitu]

botnet destroyed with a single unicode character 👍

[nle-odoo]

I searched a bit more, this is an issue only since chrome 71.

If we have 3 fields that chrome see as "address-like", eg (jsfiddle):

<input placeholder="City" autocomplete="off"//>
<input placeholder="State" autocomplete="off"/>
<input placeholder="Country" autocomplete="off"/>

chrome totally ignores autocomplete="off".

So the heuristic seems to be: if there is 3 or more address-like field on a page, ignore autocomplete="off" for all address-like field on that page.

I added a report for this exact issue in this existing bug report for chromium 71: https://crbug.com/923895#c5

[nle-odoo]

merged in 10.0 with 90c1af1151c

[JulienCochuyt]

The new solution is more simple and seem to work well but there is downside such as: someone selecting input[placeholder="Country"] in CSS or javascript, and I don't know how screen reader would react.

This approach definitely breaks screen readers ability to properly report the placeholder.
Tested with JAWS 18.0 and NVDA 2018.4