Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web_editor: stop wrapping text in p on delete in anchor #31222

Closed
wants to merge 1 commit into from

Conversation

Zynton
Copy link
Contributor

@Zynton Zynton commented Feb 19, 2019

This notably fixes a bug with the accordion snippet (website) where selecting a title and typing seemed to add a newline.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added seen 🙂 CI 🤖 Robodoo has seen passing statuses labels Feb 19, 2019
@C3POdoo C3POdoo added the RD research & development, internal work label Feb 19, 2019
Copy link
Contributor

@pparidans pparidans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
But could you insert the description (first comment) in the commit message. Thx 😉

@Zynton Zynton force-pushed the master-summernote-accordion-age branch from aedeacd to 4008695 Compare February 19, 2019 09:44
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Feb 19, 2019
@Zynton
Copy link
Contributor Author

Zynton commented Feb 19, 2019

Done :-)

This notably fixes a bug with the accordion snippet (website) where
selecting a title and typing seemed to add a newline.
@Zynton Zynton force-pushed the master-summernote-accordion-age branch from 4008695 to e71f3de Compare February 19, 2019 09:46
@pparidans
Copy link
Contributor

@robodoo r+

@robodoo robodoo added r+ 👌 CI 🤖 Robodoo has seen passing statuses labels Feb 19, 2019
robodoo pushed a commit that referenced this pull request Feb 19, 2019
This notably fixes a bug with the accordion snippet (website) where
selecting a title and typing seemed to add a newline.

closes #31222
@robodoo
Copy link
Contributor

robodoo commented Feb 19, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 19, 2019
@pparidans pparidans deleted the master-summernote-accordion-age branch February 19, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants