Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web_editor: properly position image handle in product configurator #31226

Closed

Conversation

Zynton
Copy link
Contributor

@Zynton Zynton commented Feb 19, 2019

The image handle (grey overlay over the image) was not properly
repositioning on scroll in the product configurator (a side effect of
not having a popover).

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

The image handle (grey overlay over the image) was not properly
repositioning on scroll in the product configurator (a side effect of
not having a popover).
Copy link
Contributor

@pparidans pparidans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@robodoo r+

@C3POdoo C3POdoo added the RD research & development, internal work label Feb 19, 2019
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses merging 👷 labels Feb 19, 2019
pniederlag pushed a commit to pniederlag/odoo that referenced this pull request Feb 19, 2019
The image handle (grey overlay over the image) was not properly
repositioning on scroll in the product configurator (a side effect of
not having a popover).

closes odoo#31226
@robodoo
Copy link
Contributor

robodoo commented Feb 19, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 19, 2019
@pparidans pparidans deleted the master-summernote-producthandle-age branch February 19, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants