Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web: ie11 autocomplete field no open itself #31271

Closed
wants to merge 1 commit into
base: 10.0
from

Conversation

Projects
None yet
2 participants
@nle-odoo
Copy link
Contributor

nle-odoo commented Feb 20, 2019

On IE11, in 10.0 up to master in some instance when creating a record
under some conditions the dropdown may be automatically opened and need
to be closed.

This has been pinpointed to 90c1af1 so it seem that a combination of
fields/code/autocomplete and changing the placeholder at one time causes
the issue.

Since IE11 lie and say it is mozilla 11.0 we just apply the 90c1af1
when the browser is chrome (we did no did this at first to have the same
behavior accross browsers).

opw-1940592

@nle-odoo nle-odoo added the OE label Feb 20, 2019

@nle-odoo nle-odoo force-pushed the odoo-dev:10.0-web-opw-1940592-nle branch Feb 20, 2019

@robodoo robodoo added the seen 🙂 label Feb 20, 2019

[FIX] web: ie11 autocomplete field no open itself
On IE11, in 10.0 up to master in some instance when creating a record
under some conditions the dropdown may be automatically opened and need
to be closed.

This has been pinpointed to 90c1af1 so it seem that a combination of
fields/code/autocomplete and changing the placeholder at one time causes
the issue.

Since IE11 lie and say it is mozilla 11.0 we just apply the 90c1af1
when the browser is chrome (we did no did this at first to have the same
behavior accross browsers).

note: there is an opened bug in chromium https://crbug.com/928305 if
solved the hack could be removed completely.

opw-1940592
closes #31271

@nle-odoo nle-odoo force-pushed the odoo-dev:10.0-web-opw-1940592-nle branch to bef027e Feb 20, 2019

@nle-odoo

This comment has been minimized.

Copy link
Contributor Author

nle-odoo commented Feb 20, 2019

robodoo r+

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 20, 2019

Staging failed: ci/runbot on 4c606f814561197466261ce4ac5a7314074b1126 (view more at http://runbot.odoo.com/runbot/build/452901)

@nle-odoo

This comment has been minimized.

Copy link
Contributor Author

nle-odoo commented Feb 20, 2019

robodoo retry one more time

@robodoo robodoo added CI 🤖 r+ 👌 and removed error 🙅 labels Feb 20, 2019

robodoo pushed a commit that referenced this pull request Feb 20, 2019

[FIX] web: ie11 autocomplete field no open itself
On IE11, in 10.0 up to master in some instance when creating a record
under some conditions the dropdown may be automatically opened and need
to be closed.

This has been pinpointed to 90c1af1 so it seem that a combination of
fields/code/autocomplete and changing the placeholder at one time causes
the issue.

Since IE11 lie and say it is mozilla 11.0 we just apply the 90c1af1
when the browser is chrome (we did no did this at first to have the same
behavior accross browsers).

note: there is an opened bug in chromium https://crbug.com/928305 if
solved the hack could be removed completely.

opw-1940592
closes #31271
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 20, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 20, 2019

@nle-odoo nle-odoo deleted the odoo-dev:10.0-web-opw-1940592-nle branch Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.