[FIX] web: ie11 autocomplete field no open itself #31271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nle-odoo
force-pushed
the
10.0-web-opw-1940592-nle
branch
from
42ec5a4
to
4f2c9f6
Compare
On IE11, in 10.0 up to master in some instance when creating a record under some conditions the dropdown may be automatically opened and need to be closed. This has been pinpointed to 90c1af1 so it seem that a combination of fields/code/autocomplete and changing the placeholder at one time causes the issue. Since IE11 lie and say it is mozilla 11.0 we just apply the 90c1af1 when the browser is chrome (we did no did this at first to have the same behavior accross browsers). note: there is an opened bug in chromium https://crbug.com/928305 if solved the hack could be removed completely. opw-1940592 closes odoo#31271
nle-odoo
force-pushed
the
10.0-web-opw-1940592-nle
branch
from
4f2c9f6
to
bef027e
Compare
|
robodoo r+ |
robodoo
added
merging 👷
and removed
merging 👷
CI 🤖
|
Staging failed: ci/runbot on 4c606f814561197466261ce4ac5a7314074b1126 (view more at http://runbot.odoo.com/runbot/build/452901) |
|
robodoo retry one more time |
robodoo
pushed a commit
that referenced
this pull request
Feb 20, 2019
On IE11, in 10.0 up to master in some instance when creating a record under some conditions the dropdown may be automatically opened and need to be closed. This has been pinpointed to 90c1af1 so it seem that a combination of fields/code/autocomplete and changing the placeholder at one time causes the issue. Since IE11 lie and say it is mozilla 11.0 we just apply the 90c1af1 when the browser is chrome (we did no did this at first to have the same behavior accross browsers). note: there is an opened bug in chromium https://crbug.com/928305 if solved the hack could be removed completely. opw-1940592 closes #31271
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On IE11, in 10.0 up to master in some instance when creating a record
under some conditions the dropdown may be automatically opened and need
to be closed.
This has been pinpointed to 90c1af1 so it seem that a combination of
fields/code/autocomplete and changing the placeholder at one time causes
the issue.
Since IE11 lie and say it is mozilla 11.0 we just apply the 90c1af1
when the browser is chrome (we did no did this at first to have the same
behavior accross browsers).
opw-1940592