[FIX] mail_enterprise: display all attachements in preview widget #31923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If res_id is not defined, this method used to crash. Made obvious by commit a26496b, which added a call to that function in the main controller of web. opw 1950403
len-foss
referenced
this pull request
Mar 18, 2019
…ed via widget Create a record. Add an attachment, using the widget (aptly named 'add an attachment'). It is not set as message_main_attachment_id. If you add the message through 'log note', then it is. We add a hook to make sure that it is set as message_main_attachment_id when added through the widget. opw 1950403 closes #31847 Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
|
robodoo r+ yes it makes no sense for record without res_id |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If res_id is not defined, this method used to crash.
Made obvious by commit a26496b,
which added a call to that function in the main controller of web.
opw 1950403
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr