Join GitHub today
[FIX] payment_stripe: regression 98fe5054c2 #32026
Thanks for the quick response, this PR and sorry for the issue.
The result is exactly the same.
In the original PR I renamed
In my version we have a local variable
In any case this is just for non-existing future code so your PR was as correct.
The current test we have are only python and are only run at most daily (because stripe would block us because of the number of request) with the number of runbot. But in this instance these test would not catch an issue.
For testing the whole scenario a customer do with e.g. a tour:
As for test, I tried a JS test, but we need to mock "$.getScript", MutationObserver, stripe reception of request and responses. So the test do not have much meaning.
The best way to test this would be to have a "tour" with a modified browser (eg. https://www.guru99.com/handling-iframes-selenium.html) but I am not sure how this would be implementable with our current testing framework.