Saas 12.2 fix component id whe #32135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures the qty_to_consume is always adapted to be the same as qty_done in the onchange on qty_processing. This patch is needed to keep the same behaviour before and after the workorder line refactoring 5ef4666
Whenrow
force-pushed
the
saas-12.2-fix-component_id-whe
branch
from
3fb2dbd
to
5518c86
Compare
robodoo
added
CI 🤖
The _compute_final_lot_domain method is implicitely multi but doens't manage the loop over 'self'
Whenrow
force-pushed
the
saas-12.2-fix-component_id-whe
branch
from
5518c86
to
86b8dca
Compare
|
robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward |
Usecase to reproduce: - Go on a Mo - Edit and Unlock - Produce the MO - Update a raw move and add a move line User error you quant write on product_qty fields. product_qty represent the reserved quantity on move line as quant's UoM. The system requires to write a product_uom_qty that represent the same quantity but in the move line UoM. Fix it by removing the fields from the view, so it's no more save. Also set the quantity done as readonly if the lines are present in the view.
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 27, 2019
Usecase to reproduce: - Go on a Mo - Edit and Unlock - Produce the MO - Update a raw move and add a move line User error you quant write on product_qty fields. product_qty represent the reserved quantity on move line as quant's UoM. The system requires to write a product_uom_qty that represent the same quantity but in the move line UoM. Fix it by removing the fields from the view, so it's no more save. Also set the quantity done as readonly if the lines are present in the view. closes #32135 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr