[FIX] mrp: mrp_workorder uninstall #32811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Install 'quality_mrp_workorder' without demo data - Go to the General Settings A warning is raised regarding the uninstallation of 'mrp_workorder'. This is due to `_onchange_group_mrp_routings`, which assumes that the installation of 'mrp_workorder' is only linked to the group `group_mrp_routings`. This is incorrect: `group_mrp_routings` might not be activated, but it might be in the dependencies of another module. Therefore, we change the logic: if we activate `group_mrp_routings`, we install 'mrp_workorder'. If we deactivate `group_mrp_routings` we do not uninstall 'mrp_workorder' if it is already installed, since it might be required by a dependancy. opw-1970910
nim-odoo
force-pushed
the
12.0-opw-1970910-mrp_workorder-nim
branch
from
9728d1b
to
ed3112a
Compare
|
robodoo r+ |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A warning is raised regarding the uninstallation of 'mrp_workorder'.
This is due to
_onchange_group_mrp_routings, which assumes that theinstallation of 'mrp_workorder' is only linked to the group
group_mrp_routings.This is incorrect:
group_mrp_routingsmight not be activated, but itmight be in the dependencies of another module. Therefore, we change the
logic: if we activate
group_mrp_routings, we install 'mrp_workorder'.If we deactivate
group_mrp_routingswe do not uninstall'mrp_workorder' if it is already installed, since it might be required
by a dependancy.
opw-1970910
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr